@NehalSahu8055
Posted
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
You forget to add
cursor: pointer;on buttons. It will be more user-friendly to add it. -
Follow
semantics ruleplacefooteroutside and below the main tag -
For image like
.svg are decorativewhich browser will not render it to be important and skip it, so it make no sense to addaltleave itblank.
<img src="image.svg" alt="">
- Try to add
accessibility featureslike aria, sr-only, title.
aria : link
.sr-only:link
I hope you find this helpful.
Happy coding😄
Marked as helpful
@kubas33
Posted
@NehalSahu8055
Thanks for your tips! Yeah I forgot about pointer cursor :|
@kubas33
Posted
@NehalSahu8055
I improved code according to your tips. Added pointer cursor, removed alt from images, moved footer outside main and added <h1> element with sr-only class.
Fell free to check it out now :)
@NehalSahu8055
Posted
@kubas33
Great!
- Just one more thing for good practice:
- Use
responsive units(rem, em, %)from next project. Explore respective use cases on google. link
