3 colum preview card component

Community feedback

• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • You forget to add cursor: pointer; on buttons. It will be more user-friendly to add it.

  • Follow semantics rule place footer outside and below the main tag

  • For image like .svg are decorative which browser will not render it to be important and skip it, so it make no sense to add alt leave it blank.

  <img src="image.svg" alt="">

  • Try to add accessibility features like aria, sr-only, title.

  aria : link

  .sr-only:link

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  0

  ---

  

  kubas33•180

  @kubas33Posted over 1 year ago

  @NehalSahu8055

  Thanks for your tips! Yeah I forgot about pointer cursor :|

  1

  

  kubas33•180

  @kubas33Posted over 1 year ago

  @NehalSahu8055

  I improved code according to your tips. Added pointer cursor, removed alt from images, moved footer outside main and added <h1> element with sr-only class.

  Fell free to check it out now :)

  1

  

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  @kubas33

  Great!

  • Just one more thing for good practice:
  • Use responsive units(rem, em, %) from next project. Explore respective use cases on google. link

  0