3 Card Preview Component

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Greetings Deva22

  • Your current meta tag <meta name="viewport" content="width=device-width" /> is missing initial-scale=1 . Adding the value initial-scale=1 instructs browsers to establish a 1:1 relationship between CSS pixels and device-independent pixels regardless of device orientation, and allows the page to take advantage of the full landscape width.
  • images are missing the alt tag , if it is a decorative image put an empty alt tag so that screen readers can ignore the image
  • you are using css flexbox and at the same time using floats. Floats are no longer really needed in this project and are no longer widely used these days. Flexbox is perfect for this challenge. To get started remove this code in your column class

  .column2, column1, column3
  { 
      width: 22%;
      height: 74%;
      float: left;
      left:17%;
      top: 13%;
  }
  

  happy coding

  Marked as helpful

  1

  ---

  

  deva22•20

  @deva22githubPosted over 3 years ago

  hey @ChamuMutezva! thanks a lot for your valuable comment!, I would surely follow-up the practices and work out the changes you mentioned above. and happy coding you too there!

  0