3 Card Component using React to create

Community feedback

• 

  Drew Hosick•60

  @drewhosickPosted almost 3 years ago

  Thanks for the tips

  0
• 

  Jason Heys•175

  @heyitsganyPosted almost 3 years ago

  I think it switching to the column layout below 1440px is an odd choice. You want to find the resolution where the horizontal layout starts looking cramped or broken and then switch to the vertical layout.

  You'll want to think about adding a h1 tag somewhere, as semantically a page must contain a level one heading. As the design doesn't have a good place for it, I'd suggest adding a h1 tag with screen reader only styling (so it's only visible to screen readers), using the title of the challenge.

  Also, if you want to get your positioning closer to the design I'd suggest making sure your min-height on your body is 100vh, then giving it a display: grid and place-items: center.

  Otherwise, this is great; the styling on the card pretty much matches the design. Nice work!

  0
• 

  Peter•170

  @PeterJan285Posted almost 3 years ago

  All three cards are switching to flex-direction: column on 1440px horizontal resolution?

  0

  ---

  

  Drew Hosick•60

  @drewhosickPosted almost 3 years ago

  @PeterJan285 I believe so yes. I do have a media query in there for it to switch below 1440px to a vertical alignment of the components

  0