3 Card Column

Community feedback

• 

  Adriano•38,100

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Bryan Roberts, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

  body {
      margin: 0;
      padding: 0;
      display: flex;
      align-items: center;
      flex-direction: column; // just if the body has two child
      justify-content: center;
      min-height: 100vh;
  }
  

  For a user to know that an element is clickable we need to use a css property, called cursor which changes the shape of our cursor and we will put the value pointer!

  The rest is great!

  I hope it helps... 👍

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Regarding your question,

  only the CSS property you are changing.

  • To properly center your content to your page, you will want to add the following to your Body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info:📚

  Centering in CSS

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The “car images/icons” in this component are purely decorative; They add no value. So their Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  • The headings in your component are being used incorrectly. Since the h1 heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The anchor tag will achieve this.

  • The button styling is not correct; it should be a solid light grey hsl(0, 0%, 95%) and when hovered a light grey border should appear.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  0