2nd fylo landing page with two columns

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello prayash,

  • If you are going to leave the logo not wrapped by <a> , it’s better to place it out the <nav> as it does not navigate the user in anywhere(only an image)

  • In class="nav__bar", instead of using a generic div to wrap the links , you put your links within an unordered list structure so that a screen reader will read out how many things are in the list to give visually impaired users the most information possible about the contents of the navigation.

       <img src="images/logo.svg" alt="Fylo">
        <nav aria-label=”primary”>
  	 <ul class="class="nav__bar"">
  	      <li><a href="#feature">Features</a></li>
  	      <li><a href="#team">Team</a></li>
  	     <li> <a href="#signin">Sign In</a></li>
  	 </ul>
        </nav>
  
  

  • Use the <form> tag to wrap class="main-section2-buttons"and class="header-section-buttons", instead of generic divs. Also , The button type is submit.

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content like icon-phone, icon-arrow , icon-quotes and icon-email are decorative. For decorative images, you set an empty alt to it with an aria-hidden=”true” to remove that element from the accessibility tree. This can improve the experience for assistive technology users by hiding purely decorative images.

  • Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is an explicit label’s for attribute value must match its input’s id value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label. (To hide the label visually but present for assistive technology, you may use sr-only class )

  • For the testimonial , you may use <blockquote>, <figure>, <figcaption>

  • Use the<nav > landmark to wrap the footer navigation with aria-label=”secondary “ or aria-label=”footer”. A brief description of the purpose of the navigation, omitting the term "navigation", as the screen reader will read both the role and the contents of the label. Thenav element in the header could use an aria-label="primary" or aria-label=”main” attribute on it. The reason for this is that, you should add the aria-label for a nav element if you are using the nav more than once on the page.You can read more in MDN

  • Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together.* For example , You may use the <address> tag to wrap the contact information for the author/owner of a document or an article (email and phone number.)

  • In class="footer-details1, class="footer-links" and class="footer-details2", instead of using a generic div to wrap the links , you put your links within an unordered list structure so that a screen reader will read out how many things are in the list to give visually impaired users the most information possible about the contents of the navigation.

  • Links must have discernible text. The social links wrapping the icons must have aria-label or sr-only text indicate where the link will take the user. Your icons are purely decorative, you'll need to manually add an aria-hidden attribute to each of your icons.

  
  	
  	      <ul class=”....” >
  	        <li><a href=”#” aria-label="Visit our facebook"> <i class="fa-brands fa-facebook " aria-hidden=”true”></i></a></li>
  	        <li><a href=”#” aria-label="Visit our twitter"> <i class="fa-brands fa-square-twitter" aria-hidden=”true”></i></a></li>
  	        <li><a href=”#” aria-label="Visit our instagram"> > <i class="fa-brands fa-square-instagram" aria-hidden=”true”></i></a></li>
  	      </li>
  	
  	    </ul>
  
  

  You may want to have a look at my solution , it might help

  Aside these, Great job on this one. Hopefully this feedback helps.

  0