2 weeks of learning

Community feedback

• 

  Rohit Purkait•460

  @codeswithrohPosted over 3 years ago

  Considering you have done this by learning only 2 weeks is great. Now, after checking out your code I would like to suggest you one tip and that is to use grid. You have used too much flex and don't get me wrong I love using flex too but in these type of scenarios, grid helps a lot. Also, your mobile-responsiveness is good but when checked in tablets, the texts spills over one another. In order to avoid that play a little with grid or a quick fix would be to use the padding wisely. Like for example, instead of using the padding you have given in your <header> tag try using "padding:3em 10em 0 0;" and you will see the spilling of the header part is solved.

  By the way, I also started a month ago and am enjoying it since then, hope you are loving it as well. Happy coding :)

  0
• 

  Fraser Watt•1,790

  @fraserwatPosted over 3 years ago

  • Quick fix would be to add alt text to all your images. Not visible to the naked eye but makes a huge difference to people with accessibility issues, using screen readers etc (I think it also might be useful for SEO, but I could be wrong there?). As simple as alt="description of image" in the HTML element.

  • You probably don't need that middle @media query, it can just be collapsed into the mobile view.

  Theres a couple of small cosmetic differences to make it more like the original. Header could be wider and the text in it bolder, testimonial boxes can take up more of the screen. But aside from that you've got it sorted!

  0

  ---

  

  Dave Horrocks•20

  @DaveyJHPosted over 3 years ago

  @fraserwat really helpful, thank you. I had noticed the alt repeatedly on the report and have since changed my local copy.

  The middle query was just me messing around with other sizes. It isn't perfect but gave me a chance to experiment. Mainly because I noticed how awful it looked at certain screen widths.

  I think I was struggling with the relationship between relative sizes and absolute, hopefully my next challenge comes out a bit better!

  Thanks, really appreciate your thoughts. I struggle with the text and keeping to the style guide weights. In particular, a lot of the time the challenge has seemingly smaller characters spaced out as if they were normal. Difficult to explain....each word takes the same real estate but the individual characters appear at like 80% size, fixed in their central point.

  Anyway...more learning for me!

  0