Design comparison
SolutionDesign
Solution retrospective
is this good-enough?
Community feedback
- @motuncodedPosted over 1 year ago
Congratulations to you in creating solution to this challenge. The items inside the body can be centered
body{ display:flex; justify-content: center; align-items: center; min-height:100vh; }
0 - @Thewatcher13Posted over 1 year ago
Hi,
To answer your question if you look at your solution and the design..what do you think? I have analayze your code...
html
- Don't use br or hr
- Don't use inline styles, it has the highest specificitty, use classes instead
- your button should have a type attribute (type=button)
- Use headings on your result/ greatsummary (don't skip the order of headings!)
- The right column is an ul
- Try to keep your code more readable
css
- Use a css reset, look on Andy's bell his website for a good and clear one
- Never ever set font-sizes in percent, but in relative (rem) https://fedmentor.dev/posts/font-size-px/
I advice you to do first the qr code challenge and learn more about html good resource: https://web.dev/learn/html/
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord