1st solution-Qr-card-component

Community feedback

• 

  Hassia Issah•50,530

  @HassiaiPosted about 2 years ago

  Replace <section> with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  The body has a wrong background-color. Give the body a background-color of light-gray. Use the colors and font-family that were given in the styleguide.md found in the zip folder you downloaded.

  There is no need to style the section.

  To center .container on the page using flexbox or grid:

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Give .one a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  For a responsive content, replace the height in .container with a padding value for all the sides and give it a fixed max-width value max-width:320px padding:16px. Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0