@AmodeusR
Posted
The card is pretty big, indeed xD But you know, for someone studying for a month? You did a great job putting all that together! I have some pieces of advice for you:
- Don't use percentages on paddings and margins. You don't want the boundaries of your content and elements changing accordingly to the user screen's width arbitrarily, only when it needs to.
- At the beginning of your css files, always give to all elements the content-box: border-box property. You don't need to learn right now what it means, but it'll save you from a lot of headaches, now and in the future. To give this property to every css element, just use the * selector.
- Work on your Github readme! Documentation is important and helps others understand the process you've been through. Do not underestimate it just because it doesn't involve coding. It's easy to find people who know how to put things together and make it ~kinda~ work, but not so many who documents its steps. Futhermore, the more you dive deep into the programming world, more you'll see how documentation is important.
This video may help you quite a lot! Kevin Powell is a really great and talented teacher, check it out :) https://www.youtube.com/watch?v=JnTPd9G6hoY
Marked as helpful
@DrunkenNeoguri
Posted
@AmodeusR
(I wrote it using Google Translate. Sorry for the awkward sentence!)
Thanks for the reply! After reading the replies, I thought I should study harder. > ▽<)/
After reading the comments, I have two questions!
-
For this solution, would it have been better to use a fixed value such as 'px'? If there is a value that can be substituted for '%', which value should be used?
-
When writing a ReadMe file, I would like to receive advice on what to write in ReadMe!
@AmodeusR
Posted
@DrunkenNeoguri We all need to study harder :P About your questions:
-
Since you're on your first steps, it's ok to use pixel values, generally all beginner's tutorial use them as well, so no big problem. However, as you progress at web development, you'll learn about relative units, e. g. rem, em, vw, vh and many others. Whenever you need to declare fixed values, relative units are the best approach. Take a look at this video from Kevin Powell as well, he explains what are, generally, the best unit to use in each case: https://youtu.be/watch?v=N5wpD9Ov_To
-
Frontend Mentor starter files guide you on how to make a good Readme for your repository, just read the readme files they provide with the starter files and you'll have a great starting point! If you want any more reference on how to write a repo though, feel free to see one of my FM challenge repos, as I use the template FM recommend us, you may get ideas on how to approach using it. If you want a headstart, this one is one of my best Readme's in my opinion 😁
https://github.com/AmodeusR/FM--nft-preview-card/
Marked as helpful
@DrunkenNeoguri
Posted
@AmodeusR Thank you for your precious reply! I will study by referring to the video you shared! XD
