Design comparison
Solution retrospective
All feedback is welcome!
Community feedback
- @Victor-NyagudiPosted about 2 years ago
Great job on getting your solution to look as close to the design as possible! The responsiveness is good too.
That being said, you have a lot of errors in the HTML validator and accessibility reports you should always take a look at before submitting a solution.
For example, one of the errors is caused by your
<img>
tags not having analt
attribute. This is bad for accessibility because people who rely on screen readers to view web pages will struggle to know what the images are about.Screen readers read out the
alt
text to people with poor eyesight, describing it to them. Furthermore, if for any reason your images fail to load, thealt
text is what's displayed next to an image icon telling users more about the image that's supposed to be there.You can fix this error by simply adding an
alt
attribute to all<img>
tags and setting it equal to something meaningful. For example:<img class='jeremyImg' src='./images/image-jeremy.png' alt='jeremy wearing a hat and smiling'>
If the images you're using don't have any meaning and are purely for decorative purposes e.g. the three dots, you should add an
aria-hidden
attribute, set it totrue
, and include analt
attribute equal to an empty string.<img class="dots" src="./images/icon-ellipsis.svg" aria-hidden="true" alt="">
Finally, if you're not going to include any variables inside your strings, I'd just use either single quotes or double quotes instead of backticks.
There are a couple of other things, but I'll let you fix these ones first.
All the best with this and your other solutions.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord