1st Attempt QR Code Component

Community feedback

• 

  John Idenyi•250

  @JohnIdenyiPosted over 2 years ago

  Hi you did pretty good for first challenge.

  • You used inline and internal CSS to style your webpage. It is okay to use internal css for a single page but is not advisable you use it for a website with multiple pages. You shouldn't use inline CSS in styling your document. The recommended way which is the best practice is to use external stylesheets.

  • Your texts don't have space around them making them touch the container. Add a padding property to the div wrapping the texts.

  • You have some accessibility issues. You don't have an h1 element in your document. Change the first paragraph to an h1 element. Every page must have an h1 element because screen readers make use of it to identify the main content to visually-impaired persons. It also helps in better optimization by search engines.

  • You should use semantic HTML elements like <main> or <section> to wrap contents in your document. So instead of this <div class="center"> you should do this <main class="center"></main>.

  I hope this was helpful!

  Marked as helpful

  1