1st attempt QR code component

Community feedback

• 

  Jesse Good•120

  @jessegoodPosted about 2 years ago

  Hi Tanya

  Welcome to frontend mentor. Here is some feedback, hopefully it will come in handy.

  1. Wrapping everything in a <main> element helps for accessibility (as they know where the main to go for the main portion of the document). Also, semantically also this is preferred.
  2. Did you look at the style-guide.md file? It provides information on fonts and colors that should be used.
  3. The <img> is missing an alt attribute. Also, type is not a valid attribute for this element.
  4. Try minimizing the use of <div>. For example you could get away with the following structure:

  <main> <img> <h1> <p>

  Also, In your CSS, you set the font-family, etc. multiple times. CSS has a notion of "inheritance". If you look at other examples, the font is often times set only once in the body as this is inherited by all other elements.

  Hopefully that helps.

  0

  ---

  

  Tanya•20

  @TanyaJuniorPosted about 2 years ago

  @jessegood thanks for the feedback

  0