1st attempt QR card component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • The repository link is outdated.

  • Upload the images to the GitHub repository, otherwise it won't show up in your solution

  • Rename the code.html file to index.html.

    When a user types a URL into their browser, the browser sends a request for the resource at that URL. later, the server will look for a default file to serve in that directory. By convention, the default file is named "index.html".

    Naming the main file of a website "index.html" allows for a cleaner and more intuitive URL structure for the website. For example, if the main file was named "code.html", the URL to access the homepage would be https://fortuneeli.github.io/1st-attempt-qr-code-component/code.html instead of https://fortuneeli.github.io/1st-attempt-qr-code-component/ which is less clear and less aesthetically pleasing.

  • The indentation of the code is inconsistent, making it difficult to read and understand. It's recommended to use a code formatter tool, such as Prettier, in your code editor to automatically format your code and maintain consistent indentation.

    It's too hard to spot if there's any tag misspelled, etc. :(

  Happy coding!

  1

  ---

  

  Fortuneeli•60

  @FortuneeliPosted almost 2 years ago

  @MelvinAguilar Thank you for the feedback, I will work on it. As for a code formatter I'm coding on a mobile phone

  0