Hi
A few issues you need to address on this
- use interactive elements for interactive behaviour. Not paragraph tags
- once those elements are updated make sure you always give interactive elements a focus-visible style. This is usually a bold outline and it's purpose is to help keyboard users know where they are on the page and be able to interact with the elements
- use min height 100vh not height
- this is unreadably small on mobile. 60% width and tiny rem values is no good for readability. Instead I suggest using max-width in rem on your component and never going smaller font size than equivalent of about 13px. (The style guide actually tells you what size the body font should be on this, and that is for mobile as well)
- it doesn't matter for this one now but next time work mobile first. Code is more performant that way, usually shorter too, and it is an established best practice
Marked as helpful
@EngineerHamziey
Posted
@grace-snow I have been learning alot from your comment, keep up the good work 😘.
@willise414
Posted
@grace-snow Terrific feedback - I really appreciate it!
Thank you!!
@EngineerHamziey
Posted
@grace-snow Hello, How're you doing?
I'll very much like you to help review minetoo.