QR-code-component-beta

Community feedback

• 

  Rostyslav Nazarenko•560

  @rostyslav-nazarenkoPosted almost 2 years ago

  Hi! Great solution!

  A few suggestions.

  • please read more about semantic HTML and how to use article and section. I, myself, still don't understand how to use them correctly. Here is a great article. That is why HTML validation report have 2 unresolved issues
  • don't set html { font-size: 16px; } because it destroys your later use of relative units. By default in most browsers font size is 16px and setting it to absolute units prevents people from setting their own font size.

  Have a great day!

  Marked as helpful

  1

  ---

  

  P

  Alper•1,010

  @adonmez04Posted almost 2 years ago

  @rostyslav-nazarenko Hi dude, the article helped me a lot. I hadn't been understanding how to use semantic tags for a while but right now I have a good perspective about them. Thanks for that...

  0
• 

  Hassia Issah•50,670

  @HassiaiPosted almost 2 years ago

  There is no need to style .container, Give the background-color of .container to the body.

  This challenge does not require a box-shadow. To center the main on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center the main on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center  the main on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Give the img a max-width of 100% instead of a width and height value.

  Replace the height in the main with a padding value for all the sides padding: 15px. Give the article a margin value for all the sides. margin: 15px.

  Give h1 and p the same font-size value of 15px, text-align: center, the rest are not needed. Give a margin-top value for the space between the text.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1