09_testimonials-grid-section-main

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Dalibor Stolarski, congrats on completing this challenge!

  Nice solution and nice code! I can see that you paid a lot of attention to your code/design. If you don’t mind I’ve some tips for you:

  Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content.

  This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Adriano•38,270

  @AdrianoEscarabotePosted about 2 years ago

  Hi Dalibor Stolarski, how are you?

  Congratulations on completing another challenge, I really liked the result of your challenge, but I have a few tips that I think you will like:

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  I noticed that at higher resolutions the grid-container is stretching, to fix this we can do the following;

  .grid-container { margin: 100px auto; max-width: 1440px; }

  I noticed that the content was not centralized to fix this we can do the following:

  body { display: flex; flex-direction: column; align-items: center; justify-content: center; min height: 100vh; }

  Hope it helps... 👍

  The rest is great!!

  Marked as helpful

  0