07-testimonials-grid-section-main

Community feedback

• 

  P

  JeremDevX•250

  @JeremDevXPosted 4 months ago

  Hey great work, however there are some points than you can improve.

  • Use semantics tags (headings, section, article...), to improve you page structure.
  • Avoid adding divs when they're not necessary. For example, adding a div for just one paragraph is not a good practice.
  • You can adjust you classnames to correctly use BEM from the start to the end of your code.

  class="card__head" //Good usage
  class="card white last" //Bad usage, could be "card--white"
  

  • Use kebab-case instead of camelCase for your variables.
  • Why did you set your font-size at 62.5% on html tag ? Just set the font-sizes where they are needed, but avoid changing the base size for all the document because it can lead you to unexpected behavior.
  • Stick to consistent class naming with BEM to facilitate the readability of your CSS code. Right now, it’s a bit hard to read.
  • When you reach 1200px breakpoint, everything is out of proportion or distorted,pay attention to this kind of detail.

  Keep it up ! :)

  Marked as helpful

  0