Design comparison
Solution retrospective
This was a fun one!! Trickiest part was working with images sizes, definitely the thing in front end I find hardest.
Still not 100% pleased with the "Graphic Design" / "Photography" section and how that changes at different page widths, so any pointers on how to approach this so the image responds more smoothly (and I don't have to rely on background colours at some points) v much appreciated! 😎
Community feedback
- @james-work-accountPosted over 3 years ago
A couple of small things I noticed:
- On mobile view, the Graphic design and Photography
<p>tag text is a light grey rather than dark green/blue respectively - On mobile, if you open the hamburger and switch to desktop view, the dropdown menu stays open instead of going back to the top
Otherwise it looks great! I've been struggling to change the colour of the sunnyside logo in the footer, I just resorted to changing the colour in the svg file itself. Interesting solution to use a filter on it, I hadn't thought of that.
1@fraserwatPosted over 3 years ago@james-work-account cheers, good spot on the hamburger menu!
thanks, yeah I should probably get more familiar with svg's, that sounds like a good solution too!
0 - On mobile view, the Graphic design and Photography
- @palgrammingPosted over 3 years ago
Looks like you are 90%
-
When you mobile menu is opened and if that browser is resized to desktop size the link in the mobile menu go away but the menu stays open and all the navigation links go away
-
Also the social icons do not have their hover state - turning white
1@fraserwatPosted over 3 years ago@palgramming Great spot, thanks! Fixed that, cheers 👍
0 -
- @magdaszszPosted over 3 years ago
Looks pretty good :) I also struggle with images. I'm still doing my version and I think I switched between putting the images as backgrounds and inline elements several times.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord