Submitted over 2 years ago
- Semantic HTML5 markup - CSS custom properties - Flexbox
@arnmnopat
Design comparison
SolutionDesign
Solution retrospective
CSS and Flexbox still is confusing, need to study and practice more.
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Arnmnopat, It looks great! you just need to put the component in <main>...</main> tage.
- All page content should be contained by landmarks, so the document should have one
main
landmark.
<main> <div class="card"> <div class="container"> <img src="images/image-qr-code.png" alt="QR Code"> <h2>Improve your front-end skills by building projects</h2> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </div> </div> </main>
Keep going... Good luck!
Marked as helpful1 - All page content should be contained by landmarks, so the document should have one
- @Sdann26Posted over 2 years ago
Adding more information to your comment @Ahmed Bayoumi
Change the h2 to h1 You should always have one h1 per page of the document.
The title should have the following text color
color: rgb(31, 50, 81)
.And finally add more padding-top to the title and more padding-down to the text below.
That would be perfect.
Good coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord