Design comparison
SolutionDesign
Solution retrospective
Feedback welcomed :)
Community feedback
- @PhoenixDev22Posted about 2 years ago
Hi Hector Ramirez,
Congratulation on completing another frontend mentor.Excellent work! I have some suggestions:
- Use the
<footer>
for the attribution, as using landmarks is important to improve navigation experience on your site for users of assistive technology.
- Page should contain a level-one heading. In this challenge , as it’s not a whole page, you can have
<h1>
visually hidden withsr-only
.
- In my opinion, the images are much likely to be decorative. For any decorative images, each img tag should have empty
alt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images.
- What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the
a>
. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site usingtarget=”_blank”
attribute, you can expose your site to performance and security issues.
hopefully this feedback helps.
0 - Use the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord