..

Community feedback

• 

  símios enfermo•440

  @FernandoChurrosPosted almost 2 years ago

  I have some suggestions you might consider to improve your code:

  • A better way to center the content is to use the display: flex;, align-items: center; and justify-content: center; properties of the Flexbox in the body by setting a height(100vh) and width( 100vw).

  • Putting the background as img in the body is not semantically recommended, it's just a background and not a page content.

  1
• 

  Adriano•38,040

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Amr Shamy, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  To improve the page design and prevent the background image from breaking at higher resolutions, we can do this:

  two different ways:

  1. Add a background-repeat: repeat-x;, the image will repeat on the horizontal axis, preventing it from breaking.

  2. Add a background-size: 100% 50vmin;, the 50vmin will set its height as the page target, and 100% will make it stretch on the horizontal axis.

  Feel free to choose one of the two!

  The rest is great!**

  I hope it helps... 👍

  0