Any feedback is welcome.
Zaid Ansari
@zaidansari42All comments
- @madkn1311Submitted over 2 years ago@zaidansari42Posted over 2 years ago
Beautifully coded as always. I want to ask that have you purposely kept the font-style and letter spacing in the stats number different than the design ?
And I would suggest you to update your readme file with a live link and screenshot.
Provide a border-radius to your .container to get the same look as the one provided in design.
Marked as helpful0 - @Chetana-047Submitted over 2 years ago@zaidansari42Posted over 2 years ago
Well, good for a starter, Couple of mistakes but it is from what you'll learn more,
- You have less border-radius for both the card and the image please increase it a bit to get more likely view.
- Use a header element for your title, so it'll be shown in bold, and at the same time please make sure to use the desired font-weight to match the design.
- I'm not sure about this one but your paragraph text looks kind-of smaller than that of the one in the design. Please re-check it.
- Provide more bottom-padding to the paragraph element. The difference in your padding is visible.
Marked as helpful0 - @madkn1311Submitted over 2 years ago@zaidansari42Posted over 2 years ago
Nicely done, But I got 4 accessibility issues, can you check mine and tell me what needs to be changed? . I read about the issue couldn't figure out the solution.
Preview is good and working, but still confused about the accessibility part. I'm a newbie and having a non-cs background. Or else can you share your source code, so i'll look and see that what Am I doing wrong in my code. and make the necessary changes as this website is expecting me to do.
0