Open to your valuable suggestions and feedbacks.
YoSoyPan
@yosoypanAll comments
- @krishna-vasudevSubmitted about 3 years ago@yosoypanPosted about 3 years ago
The most glaring issue I see is the line breaks not matching the reference. This can be fixed with <br> tags and defining the width of the text in question. Defining the width will ensure that your line breaks stay consistent and don't get messed up and resizing. I provided a fix in a pull request on your GitHub so you can see this in action. Overall great job Debraj!
1 - @maym42Submitted about 3 years ago
Hi there, I would love to get feedback on my code! 🤩
@yosoypanPosted about 3 years agoI would recommend getting the exact dimensions of the container in the reference photos. You can do this with an app like Pixelzoomer or whatever you fancy. Then, define those dimensions (width, height) in the style of your main-container class and that will eliminate the stretching. Great work, keep tapping!
Marked as helpful0