Skip to content
OverviewSolutions
3
Comments
2
Yeison Reyes
@yeisonreyes07

All comments

  • Chris Soncrant•60
    @chrissoncrantSubmitted about 3 years ago

    Hello all,

    I am curious as to thoughts on the Custom button. How is my design? Is there a more elegant solution to this? The custom button in the project file jpg which showed the active states made no sense to me because how is the user going to submit the value being there was no actual button to do so? I couldn't figure our how to put an input within the body of a button which is what the project file seemed to show.

    Another thing I am curious about is the layout. The layout in the project file made no sense. Why would the "number of people" input be below the actual tip buttons? To me this is like putting a Submit button in the middle of a form. So I changed it. It makes much more sense to me with this layout. Perhaps I am missing something though.

    To all those who leave feedback: Thanks so much!

    Vanilla JS, CSS, HTML, Regular Expressions, DOM Manipulation

    2
    Yeison Reyes•80
    @yeisonreyes07Posted about 3 years ago

    Hello! you app dont cant finish the calcule alright for example i try calculate a tip the 50% for 10$ and result was 7.5% in total but tip amount for person if is correct

    Congratulations for you porject and keep learning, good luck

    If you can send a feedback in me project will thanks

    0
  • Sophie•60
    @sophieQuinSubmitted about 3 years ago

    Hi there,

    I have done it ! I am quite happy with myself to actually finish the challenge.

    This was my very first DOM Manipulation challenge, so it really took me a while to get there.

    This was a great challenge and really tested my knowledge on some area. So a lot of reading was involved.

    Although, I couldn't quite figure out why I need to include document method such as "let myBill = document.........value" inside my function on not just apply a variable name to it and just use that variable in my function. It seemed to only accept it that way ?

    Thank you for any feedback you would give me, I appreciate your effort !

    Sophie

    Tip Calculator App

    2
    Yeison Reyes•80
    @yeisonreyes07Posted about 3 years ago

    Hello! I see two issues what, i tell first this app don't finish the calcule right for example if you want calcule the 50 porcent in a tip for 100$ divide bethwen 2 person this result total is 150 and too I would like to see the calculator in the center and middle the screen

    Congratulations for you project and keep learning if you want realize a feedback in me profile https://www.frontendmentor.io/solutions/tip-calculator-app-in-spanish-with-react-js-NHLLlucxd

    Thanks!

    Marked as helpful
    0