Skip to content
OverviewSolutions
11
Comments
3
Virlus Jeanty
@vjeanty02

All comments

  • Virlus Jeanty•170
    @vjeanty02Posted about 2 years ago

    Hello @Xermelly, You did a good job on your challenge

    Howerver, I have the following to say:

    • It is important to always create a readme file in your repository Try to maintain a clean repository using GitHub best practices. For more information see the following link : best-practices-for-projects
    • Then you need to add the right colors to your title and your paragraph in the css code. Try to name your classes and variables so that other developers can read them. Instead of saying c1, c2, c3 for colors, preferably use color-primary, color-secondary, color-tertiary. -If you're having trouble naming your CSS classes, see the following link : Google HTML/CSS Style Guide. Otherwise, you can use the BEM methodology. See the following link for more information : BEM

    I really enjoyed reading your code. Regards.

    Marked as helpful
    0
  • Virlus Jeanty•170
    @vjeanty02Posted about 2 years ago

    Hello, Congratulations on your challenge

    However, I have some tips for you. The HTML <section> element usually starts with a title (h1-h6). If you are having trouble with <section> and <article> tags, you can use a <div> instead. For more information see the following link:Dev-Mozilla

    Other than that, it is a great job. I am looking forward to seeing your next posts. Keep up the good work.

    Marked as helpful
    0
  • StevenGerman•100
    @StevenGermanSubmitted about 2 years ago

    Hello 😁 here my little solution to this challenge.

    QR Component

    2
    Virlus Jeanty•170
    @vjeanty02Posted about 2 years ago

    Good work ! however, I suggest that you always add a readme file in your github repository

    Marked as helpful
    0