Skip to content
OverviewSolutions
0
Comments
4
Malik Safwan
@ssafwann

All comments

  • Kallakuri Sahitya•100
    @Sahitya2006Submitted over 2 years ago

    Faced problem during enabling of responsiveness to the project. Explanation and guidance regarding "Responsiveness tips and tricks" needed. Thanks!

    SCAN CODE CARD

    1
    Malik Safwan•60
    @ssafwannPosted over 2 years ago

    Not bad, but there are some things you can work on. The main problem is how you positioned the QR code component, I see that you used the following CSS property transform: translate(800px,190px); You shouldn't do this because it placed the container in a weird position. Instead, if you want to center something in the middle of the screen use margin: 0 auto; and set a max-width; I don't know how to explain it that well so you may visit this URL for more information: http://web.simmons.edu/~grovesd/comm244/notes/week6/center. If you use this method of positioning the container in the center, you will find that you have to write fewer media queries, because the container will always be positioned in the center no matter the size of the device. But you may have some problems if you set a max-width too large, so you may need to change that in your media query.

    0
  • Malik Safwan•60
    @ssafwannPosted over 2 years ago

    It's okay if it took 7 hours because you did a good job. I have some suggestions for you, next time instead of setting a width and height on the image, just set width: 100% to the image. By setting it the width to 100%, the image will be 100% the width of the container. The picture will then always be right inside the container. This will really help you later on when you want an image to responsive to its container. Other than that good job, I also like the box-shadow addition you added.

    Marked as helpful
    0
  • Malik Safwan•60
    @ssafwannPosted over 2 years ago

    Looks good, just increase the size of ".box-one" as it's a bit too small on the desktop version. Other than that I would say to name your HTML elements a bit better. So instead of .bold write .heading, by doing so the HTML classes have a bit more meaning.

    Marked as helpful
    0
  • Malik Safwan•60
    @ssafwannPosted over 2 years ago

    Not bad, definitely certain things you can improve on. One main thing I can say is to put more spacing below the second paragraph, right now it is too cramped up. Also, after looking at your code I saw that you added the font-family property for every element. That is unnecessary, next time if you want all elements to have the same font then just do this. By using this method all elements will now have use the font "outfit".

    body { font-family: 'Outfit',sans-serif; }

    Marked as helpful
    0