Hello Developers!!!
I am Kaushal 🚀🚀🚀, And this is my solution, feel free to suggest any improvement in the code.
Skill used:
Hi,
Your project looks cool, but there is a lot things to improve. Sizes of fonts and elements are much different than in design. Some elements arent centered, and well-positioned.
I really like your slider which runs smooth.
<p class=" tggl" id="tggl_1" onclick="toggle(this)">1</p>
<p class=" tggl" id="tggl_2" onclick="toggle(this)">2</p>
<p class=" tggl" id="tggl_3" onclick="toggle(this)">3</p>
Never cast function to js events in html. Script should be separated from html document.
In this case you can get these elements by document.querySelectorAll('.tggl') and add listeners to every item in loop.
There are some other issues like duplicated id's or typos in names but i hope you are going to fix it asap.
Keep it up
-Here is my next solution, I really enjoyed it. I had some difficult with the sizes (for example I still down know how to disappear the random margin around the content)
-Please check it your and leave a comment with some advices! :)
All the bests, Colorz.
Hi, Your solution have correct layout. Semantic HTML isn't important for newbies but later you will have to learn and implement it. There is no box-shadow, border-radius on container and some other missing styles. In starter files you have style-guide file which includes all colors and fonts for project. For me you should learn BEM, it makes code reusable and much cleaner. Code is readable and fine formatted.
Keep it up.
