All comments

• 

  John Collier•10

  @jpcollierSubmitted almost 2 years ago

  I had trouble sizing the white box to fit the QR code.

  

  Frontend Mentor QR Challenge

  2

  30
  

  Marko•80

  @smarko-webPosted almost 2 years ago

  to start, congratulations to your project

  Some improvements:

  • add html landmarks (main and footer)
  • move the attribution into footer
  • add min-heightto body in css insure that everything is contained within the body
  • In my opinion the QR code did not to be in a div

  In all Good Work and stay motivated

  0
• 

  Kevin K Wang'ombe•40

  @kevinwangombeSubmitted almost 2 years ago

  Hello! All Feedback are welcomed.

  

  QR Scan Code challenge

  2

  30
  

  Marko•80

  @smarko-webPosted almost 2 years ago

  Congratulations on your first project!

  Some improvements

  • Adding landing marks I.e main and footer
  • You don’t really need to give everything a class name, just target by elements
  • Use flexbox where you have container
  • Centralize the card by css main {display: flex; justify-content: center; align-items:: center;}
  • Needs some improvement for mobile (although not bad for starters)

  What I like

  • Good UI
  • Your effort

  Keep up the good work, stay motivated

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  g-zan•10

  @gzandiemerSubmitted almost 2 years ago

  I would like to know better ways to make this design with pure css.

  

  responsive qr code with pure css

  3

  20
  

  Marko•80

  @smarko-webPosted almost 2 years ago

  First off, Congratulations on your project!

  Some improvements:

  • Add minimum height to the body (use vh unit) to have everything wrapped in the body
  • The way I did mine is using flex box, I encourage you to learn it and apply it to the card

  Hope that helps

  Marked as helpful

  0