Rating_Component_React
whitehatns
@platypus567All comments
- @MostafaKh1Submitted over 2 years ago@platypus567Posted over 2 years ago
Main points to consider: The functionality of showing all numbers up to the highlighted selection is nice, but the issue is that the submit simply does not work. To accomplish this, you should make the submit make the main card display none, and instead display the new card thanking the user. Secondly, the color palettes could be more accurate but thats a minor thing. Good luck on future projects!
0 - @123Satyajeet123Submitted over 2 years ago
please provide suggestions and improvement in my code and design. Thanks i am learning a lot while doing these challenges.
@platypus567Posted over 2 years agoA few issues to review. Firstly, the heading text should be justified to the left, which can be done using text align in css or bootstrap using text-justify. Secondly, the font for the reviews on top should be larger weight, its much lighter than the original design. Secondly, the "verified buyer" should be directly under the names of the individuals, which can be done with either padding or using the transform:translate feature on the y axis. Aside from that, you have the basic idea down, but I would look at those issues and also reviewing the mobile design in the dev tools, it looks slightly off center to me when I downsize the screen. Keep it up!
0 - @ArjunjvSubmitted over 2 years ago
Feedbacks are welcome.
@platypus567Posted over 2 years agoOnly issue I can see is that the divs are much shorter than the design, although it still looks alright. Overall I think you did a good job, might want to resize them just a bit on the desktop version.
0 - @spokeydokey26Submitted over 2 years ago
I'm still unsure if the way I am sizing these cards is the proper way to do so. Should I be explicitly setting the max-width, or should the size of the card be organically growing/shrinking as the screen size changes? Any thoughts are appreciated!
@platypus567Posted over 2 years agoYou can let it grow as the size changes if you wish to make it appear with a size ratio pertaining towards the screen it's on, so to speak. However, it looks great and is accessible. Your code was also very readable, and I found your css especially to be formatted well. Great work!
0