Skip to content
OverviewSolutions
2
Comments
2
Pedro Klepa
@pklepa

All comments

  • Aniket•160
    @AniketMJSubmitted almost 4 years ago

    It took me a lot of time to make this project as it was my first time using tailwindcss(really!!).

    So, any suggestions/tips to improve are highly appreciated!😊

    Tailwind Css, HTML, JS

    1
    Pedro Klepa•80
    @pklepaPosted almost 4 years ago

    Really well done, mate! I've never user Tailwind before but I thought your mobile menu animation was quite clean.

    There are a couple of things that I noticed that if addressed, could make your implementation even better:

    • Your fonts are overall a little small. The Style Guide of the challenge states that the base font-size should be 18px and it really makes a difference to properly take advantage of the provided typography.

    • On a similar note, your max-width for the content is set to 1536px instead of the suggested 1440px from the styleguide. (On my implementation I used 1240px as I found it to be little neater)

    • The way you handled the API errors is super cool and I think I'm going to copy to my own version, but you should probably fix the spacing for long messages as it is overlapping with the button on smaller screens.

    Great job overall! Cheers!

    1
  • Pedro Klepa•80
    @pklepaPosted almost 4 years ago

    Hey Karim! The template comes with a style-guide that states which fonts are used in the project:

    Simply include a link call on your index.html from Google Fonts and you are ready to use them.

    1