All comments

• 

  Kirsten Korevaar•40

  @oknonoSubmitted about 3 years ago

  • What is the best way to use SVGs in this context? Especially considering they need to change color in hover in the footer

  

  Sunnyside Agency

  3

  30
  

  Bibek Pant•85

  @pantbibek21Posted about 3 years ago

  Hey @oknono, this site seems so beautiful. You did a great job. Keep practicing !

  0
• 

  Shin Thant•140

  @Shin-ThantSubmitted over 3 years ago

  I didn't use the background-patten.svg as I don't like this. Instead I added the other background color! I hope it will be okay.

  

  Order Summary Component with HTML and CSS

  1

  20
  

  Bibek Pant•85

  @pantbibek21Posted over 3 years ago

  As for the accessibility issues,

  1. You can remove this div class="main-section" as main class="card" or main class="main-section" . Our body should have one main element. This is not mandatory but it is recommended if we don't want to bring any accessibility issues.
  2. Since we are only building the card and you have used h2 for heading. That is fine if we had another h1 as heading above. So that is causing problem. Better to use h1. If you feel h1 is too big. You can still adjust size through css.
  3. You text of paragraph is not aligned perfectly. See it is kinda of awkward just to have a single word take whole line space. You can manage that by using br where you want to break and also maintain it by giving margin or padding to make it nicely arranged. I also new to web development. Hope this helps. PS. Did you used SCSS in your css? How did you used that :root { --primary-clr: rgb(31, 31, 100); --secondary-clr: rgb(131, 151, 179); --dark-blue: rgb(61, 26, 185); } What is called this method of writing css? Other is absolutely fine. You are doing great.

  0