Skip to content
OverviewSolutions
10
Comments
5
Obaida Shurbaji
@obaidash99

All comments

  • Obaida Shurbaji•250
    @obaidash99Posted over 2 years ago

    Nice work you did here! Keep it!

    I think you could do better in the background of the sections after the stat section, it is better to give the background to a parent div with a width of 100%, to make it overflow outside the width of the content as it is supposed to be in the challenge design.

    You could grab your content in main tag for more semantic HTML. where you have header then main then footer. It is a landmark of HTML.

    The input inside the form element should have a label attribute in it. It is an accessibility issue.

    Hope this helps! Obaida

    0
  • Macdeesh•610
    @macdeeshSubmitted over 2 years ago

    Hello everyone !! If you have any comments or suggestions to improve my code, feel free to comment. Your feedback is appreciated. Thank you.

    Profile card component

    2
    Obaida Shurbaji•250
    @obaidash99Posted over 2 years ago

    Nice work you did here! Congrats.

    There is only the issue of accessibility, the code should contain at least one h1 heading for more semantic HTML. And don't skip the numbering of the heading, that means when you write an h1, you should write an h2 next time you need a smaller heading or something, then you can style them as you want them to be.

    Hope this helps!

    Marked as helpful
    0
  • Obaida Shurbaji•250
    @obaidash99Posted over 2 years ago

    Nice work you did here! Congrats.

    There is only the issue of accessibility, the code should contain at least one h1 heading for more semantic HTML. And don't skip the numbering of the heading, that means when you write an h1, you should write an h2 next time you need a smaller heading or something, then you can style them as you want them to be.

    Hope this helps!

    Marked as helpful
    1
  • Obaida Shurbaji•250
    @obaidash99Posted over 2 years ago

    Hi 👋 Nice job you did here!

    The design is responsive on small screens and working smoothly. Well done.

    To clear the accessibility issues grab all the content of the code body in a main tag. That will solve one problem.

    The other thing that your code should at least have one h1 heading, and don't skip h2 then going to h3, you can always keep the accurate numbering of the heading and style them as you want.

    Hope this helps. Obaida

    Marked as helpful
    0
  • Obaida Shurbaji•250
    @obaidash99Posted over 2 years ago

    Nice job you did here.

    I think it is better to put the main image inside its own tag in the index.html file, not as a background of the anchor tag.

    Make the hover effect for all elements you want by creating pseudo-elements for the photo, ::before-element as the green background and ::after-element as that eye icon. giving both the pseudo-elements and the image a ' transition: 0.3s; ' if you want a smooth effect.

    Hope it helps. Obaida

    1