Hello everyone, i have completed "sunnyside-agency-landing-page-main" challenge, Please give me feedback , thank you.
Natnael Fanta Teffera
@nasheeAll comments
- @nasheeSubmitted about 3 years ago
- @nasheeSubmitted about 3 years ago
Hello everyone, i have completed "sunnyside-agency-landing-page-main" challenge, Please give me feedback , thank you.
- @nasheeSubmitted about 3 years ago
Hey i have just completed this challenge please give me your feedback
@nasheePosted about 3 years agoi created div element with "hide" class . i used z-position with higher number so that can be displayed above the header element. the property and the value of the hide class is "display : none" that is the default value. and the i used java script to add and other class called show which can has "display: block". and when the button is clicked , javascript add "show" class and " remove " hide class. for more information please take a look at this link https://www.w3schools.com/howto/howto_js_toggle_hide_show.asp https://stackoverflow.com/questions/21070101/show-hide-div-using-javascript
1 - @B0R155Submitted about 3 years ago
Couldn't really figure out how to fix the background image. Also that 5th card doesn't look exactly as it is supposed to in the desktop variant. If someone has any ideas for fixes, please write them :)
Edit: Background position fixed.
@nasheePosted about 3 years agooh, i checked it in the large screen , it works fine
Marked as helpful0 - @B0R155Submitted about 3 years ago
Couldn't really figure out how to fix the background image. Also that 5th card doesn't look exactly as it is supposed to in the desktop variant. If someone has any ideas for fixes, please write them :)
Edit: Background position fixed.
@nasheePosted about 3 years agohello, i tried it it is not responsive, it is just mobile version, the grid is not applied on large screen according to design
0 - @nasheeSubmitted about 3 years ago
Hello All, Please give me your feedback.
@nasheePosted about 3 years agoHello Alex, I have improved the design based on your suggestion.
0 - @nasheeSubmitted about 3 years ago
Hello All, Please give me your feedback.
@nasheePosted about 3 years agoThank you! Alex, I will go through it and fix the issue.
0 - @nasheeSubmitted over 3 years ago
Hello All this is my first post on html css project would you please watch the codes and send me feedback? thanks
@nasheePosted over 3 years agoThank you for the feed back, i have updated them now, but this comment is not clear "Try to add padding-right and padding-left on your body when the card is just one column to prevent the card touching the right and the left of the screen."
0