@TkharkhelauriSubmitted 9 months ago
isaac nabil
@nabil4416All comments
- @nabil4416Posted 9 months ago
Nice work, i like how you realize the project, however, I have a small remark, you forget to put no-repeat in background image properity body { background-image: url(images/bg-mobile.svg); background-repeat: no-repeat; }
0 - @davidghignoneSubmitted 9 months ago@nabil4416Posted 9 months ago
Good job, i like how you use vh and rem for sizing, i have some ideas if would like to:
- for h1 try this : font-weight: 600;
- for social media icon, make it smaller, try: width: 40px and height: 40px, instead 45px.
- for background svg try this for responsive layout: body { background-image: url(images/bg-mobile.svg); background-repeat: no-repeat; }
Marked as helpful0 - @jnalstSubmitted 9 months ago@nabil4416Posted 9 months ago
it was good idea to use <ul> and "<li>, nice work
Marked as helpful1 - @WizardRRRSubmitted 9 months ago
EZ
@nabil4416Posted 9 months agohi, great job, it was a good idea to use the "flex" regarding the "border-radius" that you used to circle the profile photo, you can use "50%" instead of "9999px", and no need to add a "height" for it.
Marked as helpful0 - @ZephyroCodeSubmitted over 2 years ago@nabil4416Posted over 2 years ago
good job Wilver Salazar, looks so good and organized, congratulations.
To avoid ACCESSIBILITY ISSUES, try using: -main tag as general container -use the h1 tag instead of h3.
continue to challenge
0 - @obaryoSubmitted about 3 years ago
I'm still struggling to remove the scroll bar. Feedback will be much appreciated. Problem fixed thank you for your help
@nabil4416Posted about 3 years agowhat an amazing solution, very simple and clean, i wonder why did you use h3 tag instead p tag. best of luck
1 - @AmodeusRSubmitted about 3 years ago
How could I improve my code? What bad pad practices did I make and what tips you have to me so I can become better?
Is my BEM naming good? If it isn't, How could I properly name things? I'm still a little bit confuse with it, tried it for my first time.
@nabil4416Posted about 3 years agoI see that all the instructions are respected, I spent the whole day to do what you did but, I still have some problems to solve, I encourage you, you are on the right path, do not forget to add margin at the top.
1
