Frontend Mentor | Malick Roungou's profile

All comments

@smithy773Submitted 7 months ago

What are you most proud of, and what would you do differently next time?

The website is fully functional, with the entered email in the form being accessible on the server's side via the POST method in the form.

Newsletter signup form with form validation CSS, JS

Malick Roungou•470

@mroungouPosted 7 months ago

Hello @smithy773,

Congrats on completing the challenge!

I noticed you are using JavaScript to control the images of the respective device widths. You can use media queries to avoid

Here's what you could do:

<div class="header-image">
        <img src="./assets/images/illustration-sign-up-mobile.svg" class="mobile" alt="">
        <img src="./assets/images/illustration-sign-up-desktop.svg" class="desktop" alt="">
      </div>

And add a media query and some other CSS:

.mobile {
    display: block;
}

@media screen and (min-width: 1440px) {
.mobile {
        display: none;
    }

    .desktop {
        display: block;
    }
}

Let me know if you have any questions and keep up the good work :)

theGamingKitten•280

@theGamingKittenSubmitted 9 months ago

Article preview component

Malick Roungou•470

@mroungouPosted 7 months ago

Great job! Your code is well-structured and easy to read :)

marvinhxc•110

@marvinhxcSubmitted over 1 year ago

Tips for responsive

Huddle Landing Page html css

Malick Roungou•470

@mroungouPosted over 1 year ago

Hi MARVINHXC congrats on completing the challenge and great work! Here are a few things that you could change to improve your solution:

the main title seems a little off from the design. I suggest you the remove the <br> in your h1 tag in the html. And in order to achieve the look in the design try adding some padding around the h1 tag in your CSS. your CSS could look like

padding: 0rem 5rem; # 0 padding on the top and bottom and 5rem on the left and right. These are just guesstimates for the right and left padding, change them as you see fit. No need to change the top and bottom padding

same for the paragraph. You could do the same thing.

Finally, I would avoid using br. I would suggest putting the element in a span or div and use css with a block statement to put an element on a separate line.

Let me know if this was helpful and if you need clarification and/or help.

Happy coding, Malick.

Marked as helpful