Skip to content
OverviewSolutions
0
Comments
3
Mohit Menghnani
@mmenghnani

All comments

  • Mohit Menghnani•55
    @mmenghnaniPosted over 3 years ago

    This looks really great. I have a minor things that I was thinking upon

    1. All img tags seem to have the photo class. Can you just use the img tag for the style?

    2. For the alt text, should it just say Daniel Clifford or something like "image of Daniel Clifford". I am curious on this one myself

    But I love this work, congrats and all the best. Cheers!

    Marked as helpful
    0
  • Mohit Menghnani•55
    @mmenghnaniPosted over 3 years ago

    This is amazing. Great work abhineet!

    If I really had to nit pick something, I had 2 questions

    1. Why did you choose a p tag for the price amounts? Like an h tag would have been better sematically? No?

    2. How are you using the annual and monthly class?

    Just curious, but otherwise I love the work

    0
  • Mohit Menghnani•55
    @mmenghnaniPosted over 3 years ago

    Hi Pedro, this looks really great. Just a few nitpicks I noted,

    1. The height changes when you hover over the buttons. I don't think that is intended behavior. You can just use the suggestion that patrick shared above!

    2. Is there any specific reason why we can't directly use button tag in the stylesheet instead of creating a new button class

    3. Also, small typo - all three images tags have the same alt text :)

    Great work, :clapping

    Marked as helpful
    1