Skip to content
OverviewSolutions
2
Comments
1
Jithu S Nair
@jithusnair

All comments

  • Edward•10
    @Coding-EdwarSubmitted about 3 years ago

    What can be done to make the card component more accessible? How can I make sure the change link can be selected using keyboard tab?

    Flexbox

    2
    Jithu S Nair•30
    @jithusnairPosted about 3 years ago

    Hi, I am not sure that the card is shrinking. <main> has a constant width and so it doesn't shrink or expand, not anything I can see anyway.

    I can tell you a few things I did notice.

    • The percentage height on <img> might be unnecessary. Removing height: 32% should not cause any issues and <img> should auto adjust its width and height.
    • No need to give the same border radius as the entire card for <img>. Instead, write overflow: hidden; on the card. By doing it this way, in-case you feel like changing the border-radius you just need to change it at one place - on the card.
    • To make body occupy, at minimum, the entire width and height you can just use min-height: 100vh; on body and it should occupy 100% width by default and therefore min-width may not be required.
    • I believe you meant to write <article> and not <aritcle>.

    Hope this helps.

    Happy coding.

    1