Jeremiah Aworetan
@jeremy0xAll comments
- @AanuTTSubmitted over 1 year ago@jeremy0xPosted over 1 year ago
Hello.
Your image background doesn't seem to fill the whole width of a large screen. You can fix that with the
background-size
property. Read through this and you should understand how to use that property - https://developer.mozilla.org/en-US/docs/Web/CSS/background-sizeHappy Coding!
Marked as helpful0 - @Dng120696Submitted over 1 year ago
any comment so I can improve my skill thank you
@jeremy0xPosted over 1 year agoHi @Dng120696,
Great work on the design! 👍
I noticed that when you hover on the
.container-img
to show the.hover-img
, the.equi-img
doesn't take up the full height of its container. I had a similar issue before, and here's a possible fix:- Give
.container-img
a height, then set the image to have a height of100%
. - You can also add
object-fit: cover;
to the image, so it covers the container completely.
Keep up the good work! 😊
Marked as helpful0 - Give
- @stephenblizSubmitted over 1 year ago@jeremy0xPosted over 1 year ago
Hi @stephenbliz!
Excellent work on the challenge!
Here's a suggestion that might help improve your code: instead of assigning a percentage width to your
.wrapper
element, you could set its width to 100% and establish amax-width
value. This approach can help your design better accommodate different screen sizes, especially on mobile devices. Additionally, you may consider adding padding to the.section1
element to help improve the overall appearance.Keep up the good work!
0