Skip to content
OverviewSolutions
7
Comments
3
iduaine12
@iduaine12

All comments

  • iduaine12•140
    @iduaine12Posted about 3 years ago

    Hi @Denismapll great design, just a few suggestions:

    • The car icons should have aria-hidden="true", because they are for decoration. Decorative image must be hidden at all times by using aria-hidden="true" attribute on the img tag.
    • Learn more should be an a tag, since it will likely to be a link rather than button in an actual website.
    • I recommend adding transition: all 0.2s; to the button and the links, this will make :hover smoother.

    Hope the notes from the above help, great work

    Marked as helpful
    2
  • iduaine12•140
    @iduaine12Posted about 3 years ago

    Hi @Chiggs-I-Am great work on this design, just a few suggestions:

    • The car icons should have aria-hidden="true", because they are for decoration. Decorative image must be hidden at all times by using aria-hidden="true" attribute on the img tag.
    • Learn more should be an a tag, since it will likely to be a link rather than button in an actual website.
    • I recommend adding transition: all 0.2s; to the button and the links, this will make :hover smoother.
    • With your card component it might be worth looking at display:flex; over grid as it is easier to make it into a column with flex-direction:column; when you shrink the screen.

    Hope the above helps, great design :)

    Marked as helpful
    0
  • iduaine12•140
    @iduaine12Posted about 3 years ago

    Hi @fbonilla02 to help with your html issue your button should be <button class="btn-container">Proceed to Payment</button> without the p tag.

    Hope this helps

    Marked as helpful
    0