Skip to content
OverviewSolutions
6
Comments
2
Abdulla
@furhart

All comments

  • bounomad•25
    @bounomadSubmitted over 3 years ago

    Hello Guys It is my first time coding in HTML and CSS.

    I used pure CSS, before using preprocessor like Sass, less, etc. I wanted to ensure to understand the basics and the structures.

    Feel free to comment or give feedback, regarding any wrong doing regarding the structures, properties , elements used.

    I am looking forward to hear from you to improve myself :)

    Regards,

    Sebastien

    First landing page using CSS Grid for layout

    1
    Abdulla•60
    @furhartPosted over 3 years ago

    Great work! The page looks nice on my desktop and phone (both orientations). Your HTML and CSS are concise and easy to read. This is seriously good work for your first time, you should be proud.

    I have a small suggestion, try align-items: center; on your grid, this should center all grid elements and gets you closer to the original design.

    Edit: the paragraph text in your aside would look nicer on a desktop if you set a max-width.

    Abdulla

    0
  • Brandon Harmon•110
    @bdharmonSubmitted over 3 years ago

    NOTE: Media queries were not needed for responsiveness. I only used media query to add a small amount of margin to the card and reposition the bottom background circle.

    CSS Grid / responsive

    1
    Abdulla•60
    @furhartPosted over 3 years ago

    Awesome work! I noticed the extra space after the image, you can get rid of that bey using 'display: absolute' on the image which takes it out of the document flow and 'display: relative' on the card.

    Besides some minor color and font size differences, you're pretty much spot on.

    0