Things i'd appreciate feedback on: -Making the open cart responsive when absolutely positioned was slightly painful, surely there's a better way? -I wasn't sure if i implemented the overlay in a DRY fashion. -on that note, i think the lightbox could've done with splitting out, and resused quite a bit of code that could of been simplified
Evan Parker
@evancp87All comments
- @evancp87Submitted almost 2 years ago@evancp87Posted almost 2 years ago
Things i'd appreciate feedback on:
-Making the open cart responsive when absolutely positioned was slightly painful, surely there's a better way?
-I wasn't sure if i implemented the overlay in a DRY fashion.
-on that note, i think the lightbox could've done with splitting out, and resused quite a bit of code that could of been simplified. I found it a challenge to reuse a lot of the components, or more i'm not sure if i did it in the best way
0 - @JCrotzerSubmitted over 2 years ago@evancp87Posted over 2 years ago
Hi Julie,
It's looking good. Your attempt could benefit from having a smaller width to make it closer to the design, as currently the solution fits the screen and butts up against the right side of the page. All it would need is a max-width to ensure that it never goes over the specific width you go with.
Happy coding!
0 - @Axab12Submitted over 2 years ago
The only thing I found difficult was making a responsive website. If you know any good place where I can get to know more about making responsive websites that would be helpful.
@evancp87Posted over 2 years agoHi Atul,
Getting responsive design right can be hard, and something that comes with practise.
One person i would highly recommend for tips for not just responsive websites, but just CSS wizardry in general is Kevin Powell, who has a very active YouTube Channel
I hope you find his channel as useful as I do!
Marked as helpful1