All comments

• 

  Katherine•100

  @rendongzhaSubmitted over 2 years ago

  In the style guide, it stated "The designs were created to the following widths:

  • Mobile: 375px
  • Desktop: 1440px".

  I am not sure what the best practice is to make the page responsive to the above screen widths. I had an @media query setting the max-width to be 400px and reducing the root font size, and then the page looked alright on my phone.

  Thanks in advance for any suggestions!

  

  NFT preview card component solution

  2

  40
  

  Mahmoud Mohamed Abd Elaziz•470

  @ehoda9Posted over 2 years ago

  Mobile: 375px Desktop: 1440px".

  • you can use a pixel-perfect helper tool or extension and use chrome developer to resize your screen to 1400x800

  0

  This comment has received 1 replyShow
• 

  Ch Mohit•260

  @ChMohitKaPageSubmitted over 2 years ago

  i couldn't update the error placeholder. Any help regarding the same would be appreciated.

  

  Responsive Sign-in page

  1

  10
  

  Mahmoud Mohamed Abd Elaziz•470

  @ehoda9Posted over 2 years ago

  fname.addEventListener('mouseout',function(){

  • that's cool and great, but in my personal opinion I prefer to use

  [keyup event] instead of ('mouseout') addEventListener("keyup",e = >)

  This makes the inputs interact with you better than waiting for the customer to move the mouse outside the inputs and if the client's mouse is not in the scope function will not run

  • for Accessibility issues, you can change div to h1

  <div class="title">
            Learn to code by watching others
  </div>
  

  • you can use the arrow function instead of anonymous function

  Marked as helpful

  1
• 

  Jonas Stempickij•50

  @JonasStempickijSubmitted over 2 years ago

  Any tips and feedback are welcome.

  How could I make it even better?

  

  Advice generator

  1

  40
  

  Mahmoud Mohamed Abd Elaziz•470

  @ehoda9Posted over 2 years ago

  Take a look here : https://github.com/ehoda9/Advice-generator-app

  0