@TrenyceCodesSubmitted over 1 year ago
Just finished another challenge. I was struggling a little big of understanding margin and box shadow but I think I got the hang of it now. Any feedback is nice and helpful. Thank you
Dawid Keyser
@dawkey95All comments
- @dawkey95Posted over 1 year ago
Hey, nice work on completing the project. 👍🏼 I like how you added the footer and tied it in with the color scheme, so nice touch there.
One thing I would suggest is just try adding some padding to your card on top and sides. Maybe try 48px of padding just to help create a little space and make the card feel a little bit more balanced.
Other than that nice job 💯
Marked as helpful1 - @kelbri10Submitted over 1 year ago
This was a great exercise to start my morning off with. The one major issue I had initially was that the cache utilized in the API caused the function to call the same quote despite waiting the 2 seconds before hitting for a new quote. I utilized StackOverflow to look up solutions in order to resolve this issue that every time the user hits the dice they would receive a new quote. The solution I ended up using includes an object cache and sets it to no cache that way the data is constantly refreshing when the dice button is clicked.
@dawkey95Posted over 1 year agoNice work on the solution. I quite like the little change with the title and the advice # with the green border. 👍🏼Cool idea to just make it that little bit more personal. 😃
0 - @hashkitti001Submitted over 1 year ago@dawkey95Posted over 1 year ago
Hey nice job with the solution for this project. 😃 I just finished it as well and thought it was quite a fun little project to learn about APIs without being overly complicated. How did you find it?
I noticed your image links are broken. Not 💯 about how to fix it without trying but one thing you could try is just look at your image path again. perhaps trying
src="./images/pattern-divider-desktop.svg"but its hard to see as I haven't tried it in my own IDE.Also I would suggest just adding some padding to your card body. I believe yours is called
container. Try maybe 48px top and sides.Otherwise nice work. 👍🏼📱
1 - @J-Manuel-NZSubmitted over 1 year ago
This was the first time I used Tailwind to complete a project. The main block was learning the Syntax but with the docs there I eventually got it.
@dawkey95Posted over 1 year agoNice solution man. The tailwind looks like it is worth giving a go in my own projects.
1 - @MrMohammedMathSubmitted over 1 year ago@dawkey95Posted over 1 year ago
Hey,
Loved seeing your solution using react and SCSS.
How did you go about passing the accessibility reports and html validation? I always end up with landmark errors etc. I use Material UI as my CSS framework but can't figure out how to pass the accessiblity/html validation reports so thought I would check with you and how you approached it.
Kind regards
0
