Skip to content
OverviewSolutions
25
Comments
1
Jonathan
@crolette

All comments

  • Luis•270
    @luibernipSubmitted over 3 years ago

    Hi community!

    Hope you are having a great day and thank you for helping me in my coding road. I have 2 questions:

    1. Can I increase font size depending on screen width without the use of media queries? I used media queries in this project but I don't find it that usefull if the project is much larger.

    2. Do you think my JS approach was alright or is there a way to make it cleaner and still scalable?

    Once again thank you for your help in my harsh but fun coding road.

    Coding Bootcamp Testimonials Slider

    2
    Jonathan•370
    @crolettePosted over 3 years ago

    Hi ! First : Nice job ! I just submitted my solution to this challenge too : https://github.com/crolette/coding-bootcamp-testimonials-slider https://www.frontendmentor.io/challenges/coding-bootcamp-testimonials-slider-4FNyLA8JL/hub/testimonials-slider-with-javascript-lFM7cori6

    I had a look to your Javascript, I am definitely not an expert, but I think you could have done it a little bit easier. Why do you toggle an active class on the testimonial ? What is the slideOut function for ?

    0