All comments

• 

  Julia Fidison MAHANDRISOA•90

  @Julia-FidisonSubmitted over 2 years ago

  Hello, any feedback will be welcome. Especially, on the media query part to make the site more responsive.

  

  Order-Summary First-Solution using HTML and CSS

  2

  30
  

  Christian Addy•20

  @criscrispyPosted over 2 years ago

  Hello Julia,

  Great work in general. A few things you want to take note of :

  • Since you have a separate style.css file, you can move all the styles to the style.css and get rid of the styles tag in the html file. So basically, this below will be moved to the styles sheet. .attribution { font-size: 11px; text-align: center; } .attribution a { color: hsl(228, 45%, 44%); }

  • You did not include the image folder so the images did not load on your site.

  • For image queries, as you already have the @media only screen and (max-width:450px) {...} which is targeting screen sizes for max-width:450px and below. You can include some media queries that target more break points.

  320px — 480px: Mobile devices (You can keep the 450px in your example)

  481px — 768px: iPads, Tablets

  769px — 1024px: Small screens, laptops

  1025px — 1200px: Desktops, large screens

  1201px and more —  Extra large screens, TV

  Read more about media queries : Free code camp article on media queries

  Marked as helpful

  0