Skip to content
OverviewSolutions
15
Comments
4
codezol
@codezol

All comments

  • LucaD•110
    @LucaDoroSubmitted over 1 year ago

    Hello,

    Feel free to comment on anyhting you find unnecessary in my code or if there was a more optimal way to do this. Also, i struggled with putting my container in the middle of the page without using margin.

    QR Code Card (Flexbox)

    2
    codezol•420
    @codezolPosted over 1 year ago

    very nice design, this shows your skill in using css, for centering the container the problem here comes form the body height , since the height is as default fitting the content if you used margin auto the centering will be just horizentally, so first do that body { height : 100vh; } then margin auto will center the contianer both horizentally and vertically , but for me i would rather use the grid like that. body { height: 100vh; display: grid: placecontent: center; } ok i hope that i was helpful keep the hardwork.

    1
  • Destyx9•100
    @Destyx-9Submitted over 1 year ago

    Wanted to challenge myself and do this in under 60 minutes, I'm a new web developer student so these conditions make it far from perfect, but it works.

    If there is anything I could have done better, please tell me!

    QR Code Component Solution

    2
    codezol•420
    @codezolPosted over 1 year ago

    great design, but your img width is a little bit more that the origin not something bit but try to make it less with max-width, istead of div as the parent element you can use main, i really liked the responsive site

    0
  • Priscilla Ilha Carbonell•20
    @PricbnllSubmitted over 1 year ago

    I still have problems with parents div or display flex or grid ? Even use absolute or relative. Try to see who is parent or child :( I couldn't position div.attribution it below the container, I put it inside the main and it went to the side so I got confused with the relative question about parent and child.....

    Wait for someone see it and tell me how can I keep improving myself

    TKS

    Result and Summary Component

    2
    codezol•420
    @codezolPosted over 1 year ago

    yeah its very confusing, but i can tell about some things that help me with that, first use inspect, in the page you are desigening click right click and inspect, it makes the process more visual, some time the parent div is so small and child div will not move any where, you can add to the style {width:100%, height:100%} as a begging to check if that is the proplem. a great thing to watch i video or two about the grid flex or position, youtube will be very helpful, good luck priscilla your desigen is great.

    Marked as helpful
    0
  • codezol•420
    @codezolPosted over 1 year ago

    nice design Jennyfer17’, about making it responsive you can try using more fluid units such as img {width:90%;}, use less px units because it tends to make the site dimensions fixed but with % dimensions of the site change with the width of the screen, also i recommened to make a div for the image and give it a width of 100%, then for the image {margin: 10px auto}, to center it horizentally, for making the website even more responsive you can use media quaries, youtube is full about media quaries lessons, i hope that i was helpful.

    Marked as helpful
    0