All comments

• 

  Jast098•40

  @Jast098Submitted over 1 year ago

  

  my take on qr code website

  3

  40
  

  backyardcaveman•40

  @backyardcavemanPosted over 1 year ago

  Good work on your first challenge! Here are a couple thoughts that could help in the future:

  First is the use of semantic HTML, which would be the difference of using the <main> tag as opposed to where you used the <section> tag. This helps with user accessibility as well as search engine optimization. https://www.youtube.com/watch?v=kX3TfdUqpuU

  Second of all is the use of units in css files. Pixels were used for font size, padding and margin when preferably you would use different units for different tasks; like em's or rem's for font size for example. Some units of measurement are absolute and some scale to the size of the application, so its good to know what works best and when. https://www.youtube.com/watch?v=N5wpD9Ov_To&t=294s

  All the best, and happy coding!

  Marked as helpful

  1