@Orekihotarou-kSubmitted 9 months ago
What specific areas of your project would you like help with?
I faced issues with calculating the right values for the month and day output. Could you please check the code and let me know where I went wrong
Ritesh_Gupta
@b4n1y4All comments
- @b4n1y4Posted 9 months ago
Hey KB, nice take on the challenge. The design looks good overall, however the age calculation looks wrong. Please check. There are a few more things that I would suggest:
- values can't be negative or 0 [suggestion: define min max boundaries for the values]
- I see you used input type number. Maybe try to remove those spinners for a nice touch.
- The date shouldn't be more than current date as we are talking about age calculator and well, how can you calculate age of someone born in future.
- When the errors pop up, the input element shifts up. I think its a flexbox mistake. maybe try aligning contents and justify content to flex-start[ I haven't checked your code so maybe you've used something else. But this is an issue]
- Additional, try to develop a logic where if the value for day month year is 1, then you show "1 month" and not "1 months".
- For mobile layout, try increasing gap between inputs and reduce the font-size
- Correct the spelling of Year
- Add the font specified in the style-guide.md file
You can reach me out for more details or check out my solution for this challenge. Hope it helps āš»
0 - @Nits-KSubmitted almost 2 years ago
ANY SUGGESTIONS WILL BE HELPFUL .
- @Nits-KSubmitted almost 2 years ago
FIRST CHALLENGE ANY SUGGESTIONS AND ADVICE ARE MOST WELCOME .
@b4n1y4Posted almost 2 years agoHey Nitin!!!
The design looks nice for your first time, though there were some issues with your HTML structure.
Connect with me @ban1ya and we'll have a chat ā
Marked as helpful1 - @markosbahgat111Submitted over 2 years ago@b4n1y4Posted over 2 years ago
Did you also face the issue where button click was not fetching data so you had to use
window.location.reload(true)?Marked as helpful0 - @devina36Submitted almost 3 years ago
Please check my code. I think is not enough.
@b4n1y4Posted almost 3 years agoHey Devina, Your final project looks nice.... What do you think is not "good enough"?
0 - @hayliegraysonSubmitted over 3 years ago
This is my first time completing a frontend mentor challenge. I want to be a professional frontend web developer in the future. Any feedback/tips are welcome.
@b4n1y4Posted over 3 years agoHey Haylie, good job on your first challenge... A few things I would like to tell you are -
-
Changing the div with container class to a main, would resolve your accessibility issue. It occurs since all your containers are divs and technologies like screen readers require a more semantic approach in web pages. So, they definitely need a main section that can be focused... It will change nothing in your design. just remember to also change the style sheet accordingly.
-
For Learn More buttons, you could try border-radius: 50px;
Try these out, and tell me if it works... All the best š Keep coding ā
Marked as helpful0 -
- @IMVillarosaSubmitted over 3 years ago
I have completed the challenge and managed to make it responsive using Flexbox. I personally think the HTML and CSS structure could be cleaner. So, any feedbacks, opinions, questions or reactions is very much encouraged and appreciated!
@b4n1y4Posted over 3 years agoIf you change the div having class stats-card to main, your accessibility issues should be resolved.
Marked as helpful1 - @leoliloSubmitted over 3 years ago
Hello, this is my first ever project and any feedback are welcome ;)
- @Tom2612Submitted over 3 years ago
My first completed project. Really enjoyed applying some of the principles I have been learning! I would like feedback on:
How to get the right color overlay for the image as I can't seem to fine-tune it to the same purple;
When in mobile mode, I can't get rid of the margin of the bottom h3 element, despite using @media query of h2 in the form: .headings:last-child { margin: none; } This doesn't take the margin off it.
Otherwise, thank you for looking and if you spot anything I didn't, I'm happy to receive feedback!
@b4n1y4Posted over 3 years agoFor color, you should use the following code: mix-blend-mode: multiply; on your #overlay element. Try this and tell me if it works...
Marked as helpful0 - @saurabh25102000Submitted over 3 years ago
Q1. I am having problem with image overflow. How to avoid it? Q2. In my code I've used separate container for text content, which is block element and contains block elements. How to deal in this type of situation when image is float: right; and text container left? Q3. Is there any good solution to align image right and text-content left? Q4. Should i use separate container for text-content or not? Q5. I have faced so many problem with image overflow inside of the "div.main-card", How to keep image always inside the container?
@b4n1y4Posted over 3 years agoBro I think you should check out my code for this challenge.. You'll certainly figure it out. You can also reach out to me on instagram @b4n1y4. Github repo for the challenge - https://github.com/b4n1y4/stats-preview-card-component-main
0 - @aminequSubmitted over 3 years ago
This was my first complete project from frontendmentor. I would like to thank the creator of the project and frontendmentor for all their efforts.
@b4n1y4Posted over 3 years agotry using mix-blend-mode for a more saturated overlay... this one kind of looks washed out.....
Marked as helpful1 - @AndreaRigchacSubmitted over 3 years ago
I'm new in the world of programming, I began with this challengue and my doubt is because in the moment i put in my variable "bodi" grid-template-columns: repeat(5, 1fr) and obviously specically in my variable "grid " grid-column: 3/5, well its was positioned correctly but I defined in other variable "body2" grid-column: 1/5; all was a disaster, becuase mine grid didn't function as i wanted. Finally i did this exercise and is similar but I think I was wrong a lot. I accept scolding but i know your advice will help me improve. PD: Sorry for my writing I speak spanish and i know that my english is a bit disastrous.
@b4n1y4Posted over 3 years agoHey Andrea, this is not bad for a beginner..... Though there are a few things that could be improved.... I see that you have used a lot of divs...... it really helps in code review if you just documented as to what is the purpose of that div.... Try using semantic HTML... No one should expect a beginner to be perfect... You should check out others' markup and styling for knowledge... Here's mine - https://github.com/b4n1y4/profile-card-component-main
Keep coding ā
0
