Austin H.
@austinh-io
All comments
- José Mama• 150
@codesByJose
Submitted
What are you most proud of, and what would you do differently next time?
WHat i learnt is to refactor code, writing codes in the raw-rest form and then making them reuseable is what this project has taught me. It also taught me that solving problem is a step by step thing, and i am glad i learnt and scaled through.
What challenges did you encounter, and how did you overcome them?
I am looking forward to writing more and more reuseable codes. I used a lot of attributes i dont know if that is ok but id be looking forward to better ways to using less attributes.
What specific areas of your project would you like help with?
all feedbacks are highly welcomed
This looks pretty good, in my opinion. One thing in particular that stood out to me is that you have a height: 100vh set on your body. I had received feedback once before that this is bad practice, and it is better to set it to a min-height instead.
Marked as helpful
0 - PTuna Erten• 220
@tunaerten
Submitted
What are you most proud of, and what would you do differently next time?
I didn't have much trouble with the CSS part. I got stuck a bit on the colored part of the cards. Initially, I did it using a pseudo-element, but then I changed it later. This part took some time. It was quite a fun project.
What challenges did you encounter, and how did you overcome them?
In the JS part, rendering the view also took a while. In my first code, I could see the view when I clicked on the daily or weekly section, but when I loaded the page, the activities didn't show up. However, I realized I only needed a single function I hadn't noticed. I think I won't get stuck on this part for so long in my future projects.
This looks great, your JavaScript is much more concise than mine was!
Marked as helpful
1 - Ravi Verma• 140
@RaviCoderWallah
Submitted
Your solution looks great, everything works seamlessly. Your HTML looks semantic and your CSS looks great too.
0 - Pshpokas270• 110
@shpokas270
Submitted
What are you most proud of, and what would you do differently next time?
Proud that i tried to use as semantic as possible in HTML section , but I think that way is much harder and I don't understand fully why things don't work as they should
What challenges did you encounter, and how did you overcome them?
dekstop version not working properly, instead of two column horizontal it is mobile one column, in mobile aspect of it doesn't pop up share section
What specific areas of your project would you like help with?
THere is alot of problem with this one but i`ll just raw dog it and leave it for later fixing
Seems as though you are already aware, but this does need quite a bit more work done in getting the layout configured.
I do like what I think you were going for, however. In particular the animation you setup when clicking the share button. It isn't working fully now, but I can see what you were going for and I really like it!
Your HTML also looks really good, just some more work on your CSS and I'm sure it will all come together.
0 - PMohd Sadaf• 460
@MsadafK
Submitted
I think this looks really good! Your CSS and HTML seem to be more concise than mine. The one thing that really stood out to me was that your circles with the numbers are more like ovals. The way I solved this for mine was by adding
aspect-ratio: 1to mine.1 - LuÃs Gustavo Gorniak• 160
@luisgustavogorniak
Submitted
I noticed that you used grid area to setup your layout. That is really cool, I did not know you could use grid like that! I will keep that in mind for my future projects.
0 - PRohloffmeister• 170
@Rohloffmeister
Submitted
What are you most proud of, and what would you do differently next time?
The responsiveness
This desktop view of this looks really good. Though if I had to nitpick, I would say some work is still needed in terms of spacing and sizing.
The only real issue I had was the mobile view. There, some of the icons overlay atop the text, making it difficult to read.
One of the easier ways to test your mobile layout would be through your web browser. If you go to inspect the page, you should find an icon that looks like a phone and a tablet stacked atop each other. If you click on that, your browser will show you what your site looks like on mobile. Using that can make it easier to develop your mobile view.
Marked as helpful
1 - Eduardo Elias Chacon• 240
@eduardoe92
Submitted
This looks well done! All I have noticed is that the mobile view is not centered like the desktop view is. I noticed that your desktop view has a top margin added to bring it down from the top of the screen, while your mobile view lacks that. It may also be related to the total height of the viewport, as the box containing your card is only as big as the card within it. I would suggest either adding more margin to your mobile view, or adding size to your body element.
0 - Lucas Tomaz Monteiro• 70
@odevlucass
Submitted
This looks great! The one main thing I noticed right away is that the cursor is a bit inconsistent, just in regards to it changing to the "hover" state when hovering over a link. I noticed that it only changes when over the text, and not the whole link, despite the background changing. The one thing I would have done was styled the entire <a> element so the whole button can be clicked, instead of needing to click on the text specifically.
0 - nathan-bark• 60
@nathan-bark
Submitted
Your solution looks great! Your CSS and HTML is very concise.
0 - Anderson Moreira Silva• 10
@anderjackie
Submitted
What are you most proud of, and what would you do differently next time?
To finish the project and to get to understand how the tags were composed.
What challenges did you encounter, and how did you overcome them?
Definitely the responsiveness of the component. But when I set the min and max of the height and width everything went fine.
What specific areas of your project would you like help with?
Which html tags are proper to use in this case.
This looks great, seems like you did a really good job. Maybe just a nitpick, but the design had 3 lines for the paragraph, while yours only has 2. I was able to achieve that for mine by setting a max-width on the paragraph's container.
Marked as helpful
1
