@kaattee27Submitted almost 2 years ago
This is a great way to learn Responsive Design and Build your first projects. This is my 2nd project and I hope that is not so bad.
Aniket Nimaje
@aniket167779All comments
- @aniket167779Posted almost 2 years ago
Hello Ketevan, Your GitHub repository is empty. I think you should look into it.
0 - @rahulswimmerSubmitted almost 2 years ago@aniket167779Posted almost 2 years ago
Replace <div class=""> with the main tag and <h3> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
* { margin: 0; padding: 0; box-sizing: border-box; }Resets the pages default margin and padding for the entire html file. This will allow you to have more control when you are styling specific elements.0 - @marcosviniciuscolaresSubmitted almost 2 years ago
All help is welcome!
@aniket167779Posted almost 2 years agoHi Marcos, nice solution! Just one suggestion you can give line-spacing=5px to h1 for some spacing between letters.
Marked as helpful1 - @joelsonlinsSubmitted almost 2 years ago
All feedback is welcome thank you in advance
@aniket167779Posted almost 2 years agoReplace <div class="container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
0 - @kartikbhaiiSubmitted almost 2 years ago@aniket167779Posted almost 2 years ago
- You can use <s > HTML element for a strikethrough on $169.99 and you can use this tutorial for screen reader.(https://www.scottohara.me/blog/2017/04/14/inclusively-hidden.html)
- You can import fonts from Google fonts.
- Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit.
Marked as helpful0
